Skip to content

Commit

Permalink
ref: unify signature of get_projects_list (#74972)
Browse files Browse the repository at this point in the history
pointed out by mypy 1.11
<!-- Describe your PR here. -->
  • Loading branch information
asottile-sentry authored and Christinarlong committed Jul 26, 2024
1 parent b5883ea commit d1153fa
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion fixtures/integrations/jira/mock.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


class MockJira(StubJiraApiClient, MockService):
def get_projects_list(self):
def get_projects_list(self, cached: bool = True):
"""
List all projects in the Jira data format.
Expand Down
2 changes: 1 addition & 1 deletion fixtures/integrations/jira/stub_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def get_priorities(self):
def get_versions(self, project_id):
return self._get_stub_data("versions_response.json")

def get_projects_list(self, cached=True):
def get_projects_list(self, cached: bool = True):
return self._get_stub_data("project_list_response.json")

def get_issue(self, issue_key):
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/integrations/jira_server/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def create_comment(self, issue_key, comment):
def update_comment(self, issue_key, comment_id, comment):
return self.put(self.COMMENT_URL % (issue_key, comment_id), data={"body": comment})

def get_projects_list(self, cached=True):
def get_projects_list(self, cached: bool = True):
if not cached:
return self.get(self.PROJECT_URL)
return self.get_cached(self.PROJECT_URL)
Expand Down

0 comments on commit d1153fa

Please sign in to comment.