fix(arm64) Fixes snuba tests on arm64 #30912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a small number of tests that were consistently failing as a result of arm64 using a newer version of Clickhouse. For a couple of the tests I skipped them on arm64 since fixing the test would require changing what it does. For the other tests I changed the lower bound on dates since the new version of Clickhouse didn't like getting 0001 as a year.
markstory
approved these changes
Jan 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a small number of tests that were consistently failing as a
result of arm64 using a newer version of Clickhouse. For a couple of the tests I
skipped them on arm64 since fixing the test would require changing what it does.
For the other tests I changed the lower bound on dates since the new version of
Clickhouse didn't like getting 0001 as a year.
For more context on these fixes: The tests that I changed the orderby were failing because they had at least 2 results with the same sorting value, which happened to be in a different order with the new Clickhouse. Changing the orderby ensured the results were arriving in a consistent order.
The change in release_health/metrics.py and utils/snuba.py to use a different minimum date is because without those, the default dates were being set to
0001-01-01T00:00:00and the epoch respectively. In the new version of Clickhouse, it uses a couple days after the normal epoch as its epoch, and dates less than the Clickhouse epoch cause incorrect results.