ref(escalating): Clean up the code #47625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These code changes are in preparation to optimizing the Snuba query.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Apr 19, 2023
| start_date, end_date = _start_and_end_dates() | ||
| project_ids, group_ids = _extract_project_and_group_ids(groups) | ||
| return _query_with_pagination(project_ids, group_ids, start_date, end_date) |
There was a problem hiding this comment.
We move the pagination logic into it's own function since it will make the next PR a lot easier to read.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47625 +/- ##
==========================================
- Coverage 80.76% 80.76% -0.01%
==========================================
Files 4765 4764 -1
Lines 201451 201441 -10
Branches 11617 11617
==========================================
- Hits 162699 162688 -11
- Misses 38496 38497 +1
Partials 256 256
|
wedamija
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code changes are in preparation to optimizing the Snuba query.