Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-states): Disable the MARK_REVIEWED feature #47689

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

snigdhas
Copy link
Member

@snigdhas snigdhas commented Apr 20, 2023

Disable the logic to mark an issue as reviewed if the remove-mark-reviewed flag is enabled. We should enable this flag as part of issue states.

WOR-2901

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #47689 (87c177e) into master (acb55ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #47689   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files        4763     4763           
  Lines      201069   201075    +6     
  Branches    11598    11598           
=======================================
+ Hits       162490   162495    +5     
- Misses      38323    38324    +1     
  Partials      256      256           
Impacted Files Coverage Δ
src/sentry/conf/server.py 93.76% <ø> (ø)
src/sentry/features/__init__.py 100.00% <100.00%> (ø)
src/sentry/issues/update_inbox.py 100.00% <100.00%> (ø)
src/sentry/models/groupinbox.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@snigdhas snigdhas changed the title feat(issue-states): Disable MARK_REVIEWED for issue-states feat(issue-states): Disable the MARK_REVIEWED feature Apr 20, 2023
@snigdhas snigdhas added this to the Issue States and Filters milestone Apr 20, 2023
@snigdhas snigdhas requested a review from a team April 20, 2023 18:29
@snigdhas snigdhas marked this pull request as ready for review April 20, 2023 18:29
@snigdhas snigdhas requested a review from a team April 20, 2023 18:29
@snigdhas snigdhas merged commit 14f1d22 into master Apr 20, 2023
@snigdhas snigdhas deleted the snigdha/mark-reviewed-be branch April 20, 2023 22:00
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants