fix(migration): iterate over project to avoid query timeouts #47720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
barkbarkimashark
force-pushed
the
sharky/group-substatus-migration-optimize
branch
from
5e38cfe
to
93880cf
Compare
wedamija
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
The reason this would be timing out is because you're trying to filter on status=GroupStatus.IGNORED while using the RangeQuerySetWrapper. RangeQuerySetWrapper adds in a sort by id, and so since there's not an index on status, id it can result in bad query plans.
Sometimes it can be just easier to RangeQuerySetWrapper over .all() and skip rows that don't match the criteria in code.
This change might fix it, or it might run into the same problem since you're still using a RangeQuerySetWrapper when filtering down to projects. Up to you if you want to try it
barkbarkimashark
added a commit
that referenced
this pull request
Apr 21, 2023
Opt to iterate over all groups and filter it down. Based on this comment #47720 (review)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPS is running into timeouts trying to run this migration. This PR tries to avoid the timeouts by iterating over projects and then querying on groups.