ref(escalating_issues): Easier to write and read tests #48102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests were time sensitive and the results would change depending on how close it would execute to midnight. This uses freeze gun in order to have a tight control on the time for the tests. This also includes some refactoring.
Before the tests would intermittently fail depending on the time of execution. Freeze gun helps making the tests resilient.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48102 +/- ##
==========================================
+ Coverage 77.73% 80.88% +3.15%
==========================================
Files 4745 4769 +24
Lines 201433 201640 +207
Branches 11542 11548 +6
==========================================
+ Hits 156577 163095 +6518
+ Misses 44601 38290 -6311
Partials 255 255 |
…armenzg/escalating/test-refactor
…armenzg/escalating/test-refactor
armenzg
commented
Apr 28, 2023
| @@ -33,27 +33,28 @@ def setUp(self) -> None: | |||
| def _load_event_for_group( | |||
| self, | |||
| project_id: Optional[int] = None, | |||
| minutes_ago: int = 1, | |||
| count: int = 1, | |||
| hours_ago: int = 0, | |||
There was a problem hiding this comment.
Using hours_ago lines up more closely with the hourly bucket we use in my Snuba query.
armenzg
changed the title
jangjodi
reviewed
Apr 28, 2023
| group.substatus = GroupSubStatus.UNTIL_ESCALATING | ||
| group.save() | ||
|
|
||
| def assert_is_escalating(self, group: Group) -> None: |
jangjodi
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the readability of the tests.