Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hybrid-cloud): save outbox messages when creating them for org members #49055

Merged
merged 6 commits into from
May 12, 2023

Conversation

dashed
Copy link
Member

@dashed dashed commented May 12, 2023

This is a proposal to introduce save_outbox_for_update() and save_outbox_for_create() methods for org members.

@dashed dashed self-assigned this May 12, 2023
@dashed dashed requested review from a team and AniketDas-Tekky as code owners May 12, 2023 21:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #49055 (cfdc570) into master (20cfcb8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #49055   +/-   ##
=======================================
  Coverage   80.90%   80.91%           
=======================================
  Files        4819     4819           
  Lines      202057   202060    +3     
  Branches    11425    11425           
=======================================
+ Hits       163479   163496   +17     
+ Misses      38324    38310   -14     
  Partials      254      254           
Impacted Files Coverage Δ
...entry/api/endpoints/organization_member/details.py 91.94% <100.00%> (-0.11%) ⬇️
.../sentry/api/endpoints/organization_member/index.py 99.29% <100.00%> (-0.01%) ⬇️
src/sentry/models/organizationmember.py 90.72% <100.00%> (+0.25%) ⬆️
.../sentry/services/hybrid_cloud/organization/impl.py 94.69% <100.00%> (-0.08%) ⬇️

... and 14 files with indirect coverage changes

@dashed dashed merged commit 55bb1fc into master May 12, 2023
@dashed dashed deleted the hybrid-cloud/orgmembers/0-save-outbox branch May 12, 2023 23:47
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants