Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-maps): adds new case for source map debugging #49061

Merged
merged 2 commits into from
May 15, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented May 12, 2023

This PR adds a new source map debugging strategy for an outdated SDK:

Screen Shot 2023-05-12 at 3 53 39 PM

We ask them to upgrade and if they are a major revision out of date, we expose the migration guide. A backend PR will be added later to generate this response.

@scefali scefali requested a review from a team May 12, 2023 22:55
@scefali scefali requested a review from a team as a code owner May 12, 2023 22:55
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2023
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, but it would be nice to have unit tests too

if (docPlatform === 'react-native') {
return 'https://docs.sentry.io/platforms/react-native/migration/';
}
return 'https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#upgrading-from-6x-to-7x';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is static we will have to keep an eye out here otherwise it would lead the user to wrong information in the future

@scefali scefali merged commit 349a466 into master May 15, 2023
@scefali scefali deleted the feat/source-map-debug-out-of-date-sdk branch May 15, 2023 15:32
volokluev pushed a commit that referenced this pull request May 30, 2023
This PR adds a new source map debugging strategy for an outdated SDK:

![Screen Shot 2023-05-12 at 3 53 39
PM](https://github.com/getsentry/sentry/assets/8533851/6a664d2c-1ce7-44b0-bb6e-b4007744c0db)

We ask them to upgrade and if they are a major revision out of date, we
expose the migration guide. A backend PR will be added later to generate
this response.
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants