fix(txnames): Always count clusterer run #49597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49597 +/- ##
=======================================
Coverage 80.97% 80.97%
=======================================
Files 4820 4820
Lines 202144 202144
Branches 11346 11346
=======================================
+ Hits 163680 163685 +5
+ Misses 38211 38206 -5
Partials 253 253
|
olksdr
approved these changes
May 23, 2023
iker-barriocanal
approved these changes
May 23, 2023
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
Count a clusterer run whenever the clusterer spawn job is scheduled and a project has collected at least one transaction since the last run. Projects that have very few unique transaction names (i.e. low cardinality) should get those metrics tagged by the original transaction name, instead of being stuck in `<< unparameterized >>` forever. #49087 already lowered the threshold, but we're still seeing a high percentage of URL transactions not getting relabeled. ref: getsentry/team-ingest#124
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count a clusterer run whenever the clusterer spawn job is scheduled and a project has collected at least one transaction since the last run.
Projects that have very few unique transaction names (i.e. low cardinality) should get those metrics tagged by the original transaction name, instead of being stuck in
<< unparameterized >>forever.#49087 already lowered the threshold, but we're still seeing a high percentage of URL transactions not getting relabeled.
ref: https://github.com/getsentry/team-ingest/issues/124