feat(project-creation): Make product selection feature available to everyone - Part 2 #50806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable-to-everyone-part-1
…ailable-to-everyone-part-2
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
changed the title
priscilawebdev
commented
Jun 13, 2023
matejminar
reviewed
Jun 14, 2023
Comment on lines
60
to
64
| const reason = hasRightsToUgradePlan | ||
| ? t('To use Session Replay, update your organizations plan to its latest version.') | ||
| : t( | ||
| 'To use Session Replay, request an owner in your organization to update its plan to the latest version.' | ||
| ); |
There was a problem hiding this comment.
I think that hasRightsToUgradePlan and messaging around upgrading plans do not belong to the sentry repo.
It should live in getsentry as OSS does not have the concept of plans.
There was a problem hiding this comment.
you are right...we should move this logic to getsentry. Thanks for the feedback... will update the code
…ailable-to-everyone-part-2
…ailable-to-everyone-part-2
priscilawebdev
commented
Jun 15, 2023
…ailable-to-everyone-part-2
matejminar
approved these changes
Jun 15, 2023
priscilawebdev
deleted the
priscila/feat/make-getting-started-docs-available-to-everyone-part-2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly updates the
ProductSelectioncomponent, adding the new propdisabledProductswhich will be used in case a product present in the list is not available in the current strategy of an organization.Note: Further work that includes cleanup and dark mode styles will be done in follow-up PRs
Related to #49936
Requires https://github.com/getsentry/getsentry/pull/10844
Preview:
Screen.Recording.2023-06-13.at.13.17.42.mov