feat(onboarding): Add code tabs to platform spring boot #56318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
Looks good to me @ArthurKnaus, the only nit Ill mention is the border color used to seperate the tabs from the code block is a bit too harsh. Is there a color available thats a bit more subtle? |
Sure, will update 👍 @Jesse-Box |
ArthurKnaus
force-pushed
the
aknaus/feat/onboarding/add-code-tabs-to-platform-sping-boot
branch
from
355455e
to
9cf59dd
Compare
matejminar
approved these changes
Sep 18, 2023
…s' into aknaus/feat/onboarding/add-code-tabs-to-platform-sping-boot
Base automatically changed from
aknaus/feat/code-snippet/add-tabs
to
master
September 20, 2023 07:27
…ing/add-code-tabs-to-platform-sping-boot
ArthurKnaus
deleted the
aknaus/feat/onboarding/add-code-tabs-to-platform-sping-boot
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #56317
Closes #56238
Closes #50226