Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apis): commit auto generated code #56698

Merged
merged 12 commits into from
Oct 11, 2023
Merged

fix(apis): commit auto generated code #56698

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d13fa92
fix(apis): commit auto generated code
sentaur-athena Sep 21, 2023
2aa1b67
adding to pull request
sentaur-athena Sep 21, 2023
226b910
commit everytime
sentaur-athena Sep 21, 2023
92bcfa9
random change
sentaur-athena Sep 21, 2023
f88f1d3
separate workflow
sentaur-athena Sep 22, 2023
c8ac391
adding to schema repo
sentaur-athena Oct 10, 2023
dc63a55
temporary call the action on pr
sentaur-athena Oct 10, 2023
f4e0507
fix remove
sentaur-athena Oct 10, 2023
1545f88
git ignore
sentaur-athena Oct 10, 2023
95f9fb5
Remove path/to/file from version control
sentaur-athena Oct 10, 2023
f69735d
hopefully it doesn't show up anymore
sentaur-athena Oct 10, 2023
48cbc92
removing temp test code
sentaur-athena Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: openapi
on:
push:
branches:
- master
pull_request:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to merge this change, only here so we can see the action on this PR.


# hack for https://github.com/actions/cache/issues/810#issuecomment-1222550359
env:
Expand Down Expand Up @@ -62,6 +60,16 @@ jobs:
run: |
cp tests/apidocs/openapi-derefed.json sentry-api-schema

- name: Copy publish status into getsentry/sentry-api-schema
if: steps.changes.outputs.api_docs == 'true'
run: |
cp src/sentry/apidocs/api_ownership_stats_dont_modify.json sentry-api-schema

- name: Remove publish status temp file from Sentry
if: steps.changes.outputs.api_docs == 'true'
run: |
rm src/sentry/apidocs/api_ownership_stats_dont_modify.json

- name: Git Commit & Push
uses: stefanzweifel/git-auto-commit-action@0049e3fa4059ca715255fbbcb7dea4516f02ce0a # v4.15.3
if: steps.changes.outputs.api_docs == 'true'
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/api/endpoints/notification_defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
@control_silo_endpoint
class NotificationDefaultsEndpoints(Endpoint):
publish_status = {
"GET": ApiPublishStatus.PRIVATE,
"GET": ApiPublishStatus.EXPERIMENTAL,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not merge this change. This is only to show these changes will be applied to the other repo. They are: https://github.com/getsentry/sentry-api-schema/blob/main/api_ownership_stats_dont_modify.json#L37

}
owner = ApiOwner.ISSUES
permission_classes = ()
Expand Down
31 changes: 16 additions & 15 deletions src/sentry/apidocs/api_ownership_stats_dont_modify.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,15 @@
"SourceMapDebugEndpoint::GET"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file won't be here if they don't run make build-api-docs locally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I put it in git ignore so people don't even see it.

],
"private": [
"NotificationDefaultsEndpoints::GET",
"UserNotificationSettingsOptionsDetailEndpoint::DELETE",
"UserNotificationSettingsOptionsEndpoint::GET",
"UserNotificationSettingsOptionsEndpoint::PUT",
"UserNotificationSettingsProvidersEndpoint::GET",
"UserNotificationSettingsProvidersEndpoint::PUT"
],
"experimental": [],
"experimental": [
"NotificationDefaultsEndpoints::GET"
],
"unknown": [
"ActionableItemsEndpoint::GET",
"GroupActivitiesEndpoint::GET",
Expand Down Expand Up @@ -93,7 +94,7 @@
]
},
"unowned": {
"block_start": 95,
"block_start": 96,
"public": [
"MonitorIngestCheckInDetailsEndpoint::PUT",
"MonitorIngestCheckInIndexEndpoint::POST",
Expand Down Expand Up @@ -552,7 +553,7 @@
]
},
"owners-native": {
"block_start": 554,
"block_start": 555,
"public": [],
"private": [],
"experimental": [],
Expand All @@ -567,7 +568,7 @@
]
},
"performance": {
"block_start": 569,
"block_start": 570,
"public": [
"OrganizationEventsEndpoint::GET"
],
Expand Down Expand Up @@ -622,7 +623,7 @@
]
},
"discover-n-dashboards": {
"block_start": 624,
"block_start": 625,
"public": [],
"private": [],
"experimental": [],
Expand All @@ -637,7 +638,7 @@
]
},
"enterprise": {
"block_start": 639,
"block_start": 640,
"public": [
"NotificationActionsDetailsEndpoint::DELETE",
"NotificationActionsDetailsEndpoint::GET",
Expand Down Expand Up @@ -708,7 +709,7 @@
]
},
"telemetry-experience": {
"block_start": 710,
"block_start": 711,
"public": [],
"private": [],
"experimental": [
Expand All @@ -727,7 +728,7 @@
]
},
"team-starfish": {
"block_start": 729,
"block_start": 730,
"public": [],
"private": [],
"experimental": [],
Expand All @@ -737,7 +738,7 @@
]
},
"growth": {
"block_start": 739,
"block_start": 740,
"public": [],
"private": [],
"experimental": [],
Expand All @@ -746,7 +747,7 @@
]
},
"feedback-backend": {
"block_start": 748,
"block_start": 749,
"public": [],
"private": [],
"experimental": [
Expand All @@ -758,7 +759,7 @@
"unknown": []
},
"replay-backend": {
"block_start": 760,
"block_start": 761,
"public": [],
"private": [],
"experimental": [],
Expand All @@ -767,7 +768,7 @@
]
},
"profiling": {
"block_start": 769,
"block_start": 770,
"public": [],
"private": [],
"experimental": [],
Expand All @@ -783,7 +784,7 @@
]
},
"team-web-sdk-frontend": {
"block_start": 785,
"block_start": 786,
"public": [],
"private": [
"SourceMapDebugBlueThunderEditionEndpoint::GET"
Expand All @@ -792,7 +793,7 @@
"unknown": []
},
"hybrid-cloud": {
"block_start": 794,
"block_start": 795,
"public": [],
"private": [],
"experimental": [],
Expand Down
Loading