feat(replays): Delete videos on replay delete request #68463
Conversation
github-actions
bot
added
the
Scope: Backend
Bundle ReportChanges will decrease total bundle size by 770 bytes ⬇️
|
| if direct_storage_segments: | ||
| with cf.ThreadPoolExecutor(max_workers=100) as pool: | ||
| with cf.ThreadPoolExecutor(max_workers=100) as pool: | ||
| pool.map(_delete_if_exists, video_filenames) |
There was a problem hiding this comment.
should we guard this with the video replay feature flag?
There was a problem hiding this comment.
I don't think its necessary. If you have a video it deletes. If you don't it does nothing.
|
@JoshFerge It would require downloading and parsing the RRWeb. |
got it. how does the replay UI for example know whether or not a replay is a mobile replay or a rrweb replay? |
|
@JoshFerge I believe they download the RRWeb first and then fetch the video once they know its a mobile replay. |
got it, makes sense. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68463 +/- ##
===========================================
+ Coverage 66.44% 79.72% +13.28%
===========================================
Files 6417 6422 +5
Lines 284175 284646 +471
Branches 48979 49034 +55
===========================================
+ Hits 188808 226942 +38134
+ Misses 94994 57337 -37657
+ Partials 373 367 -6
|
If we did not delete this the videos would remain in storage until the retention-period expires.
Relates to: #63255