feat(feedback): Add a mailto link, and make it easy to copy an email address in Feedback Details #68666
+243
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…address in Feedback Details
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 18.33kB ⬆️
|
|
Can we make it more obvious that you can click to copy to clipboard? Maybe a tooltip or change to the pointer cursor? |
@c298lee thats a good idea, I'll put it in for sure |
c298lee
reviewed
Apr 11, 2024
| title: string; | ||
| value: string; | ||
| initial_priority?: number; |
There was a problem hiding this comment.
needed to make the types work. the real response in the browser has it so i think it was either recently added to issues, or we just missed it when we did the types the first time around.
c298lee
approved these changes
Apr 11, 2024
c298lee
pushed a commit
that referenced
this pull request
Apr 12, 2024
…address in Feedback Details (#68666) There's a new send-email button that uses a `mailto` to open your email client and let you start typing. <img width="405" alt="SCR-20240410-nufl" src="https://github.com/getsentry/sentry/assets/187460/d006f918-85d3-410a-b14f-06171c430bc5"> Clicking on the name/email text will highlight all of it in blue (as shown) and copy "Josh Ferge <josh.ferge@sentry.io>" onto the clipboard: <img width="320" alt="SCR-20240410-nufy" src="https://github.com/getsentry/sentry/assets/187460/c8affee4-8dd3-4be6-acc3-d071941d52fa"> It's standard format, mail clients will allow you to paste it. It's nice because it includes both parts in a well formatted structure (i generally find it's easier to remove extra bits if needed compared to having to copy+paste more often). Also, this change makes it so if someone types the same thing into the name & email fields we'll only show it once. Fixes getsentry/team-replay#414
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new send-email button that uses a
mailtoto open your email client and let you start typing.Clicking on the name/email text will highlight all of it in blue (as shown) and copy "Josh Ferge josh.ferge@sentry.io" onto the clipboard:
It's standard format, mail clients will allow you to paste it. It's nice because it includes both parts in a well formatted structure (i generally find it's easier to remove extra bits if needed compared to having to copy+paste more often).
Also, this change makes it so if someone types the same thing into the name & email fields we'll only show it once.
Fixes https://github.com/getsentry/team-replay/issues/414