You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows #69232 which removed some optimistic updated that would cause crazy re-rendering. Instead we'll just invalidate (and re-fetch if needed) the /viewed-by/ endpoint data.
The reason will be displayed to describe this comment to others. Learn more.
Would this refetch on the same page view? Ie if I visit replay details for first time would my avatar be in the viewed by? Or would it just invalidate for the next page view?
Would this refetch on the same page view? Ie if I visit replay details for first time would my avatar be in the viewed by? Or would it just invalidate for the next page view?
Fixed it so it'll refetch on the same pageview. This makes it so your own icon will pop into place after you view a replay for the first time.
Would this refetch on the same page view? Ie if I visit replay details for first time would my avatar be in the viewed by? Or would it just invalidate for the next page view?
Fixed it so it'll refetch on the same pageview. This makes it so your own icon will pop into place after you view a replay for the first time.
@ryan953 FWIW this differs from issue details where we never see ourselves in the view by list (which I guess makes sense on the details page since you'll always have viewed it).
Would this refetch on the same page view? Ie if I visit replay details for first time would my avatar be in the viewed by? Or would it just invalidate for the next page view?
Fixed it so it'll refetch on the same pageview. This makes it so your own icon will pop into place after you view a replay for the first time.
@ryan953 FWIW this differs from issue details where we never see ourselves in the view by list (which I guess makes sense on the details page since you'll always have viewed it).
that's true. the issues page uses a component the filters out the current user from the list. I'd go for that, but i remember we also got feedback that the empty state on Replay Details look funny, and i think it's often the case that a replay hasn't been seen by anyone yet, so it might be more important to solve that too.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Scope: FrontendAutomatically applied to PRs that change frontend components
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
Scope: Frontend
This follows #69232 which removed some optimistic updated that would cause crazy re-rendering. Instead we'll just invalidate (and re-fetch if needed) the
/viewed-by/endpoint data.This is related to the viewed-by replay project:
https://github.com/getsentry/team-replay/issues/19
#64924