Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(insights): abstract ScreenLoadSpanSamples side panel for mobile modules #70890

Merged
merged 2 commits into from
May 15, 2024

Conversation

KevinL10
Copy link
Contributor

@KevinL10 KevinL10 commented May 14, 2024

Currently, the app starts module depends on ScreenLoadSpanSamples in mobile/screenload to display the side panel. However, we therefore cannot identify which module the panel comes from, which we will need for analytics (e.g. # of times a sample span is clicked per module) - #70822.

This PR moves the component under mobile/components and adds a moduleName prop to identify the originating module.

@KevinL10 KevinL10 requested a review from a team as a code owner May 14, 2024 21:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2024
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@KevinL10 KevinL10 force-pushed the kevinliu/ref/mobile-sample-panel branch from 16c919f to 4155cd8 Compare May 15, 2024 13:48
@KevinL10 KevinL10 merged commit 474ca1a into master May 15, 2024
40 of 41 checks passed
@KevinL10 KevinL10 deleted the kevinliu/ref/mobile-sample-panel branch May 15, 2024 14:06
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants