Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(similarity): use get_primary_hash in backfill #72022

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

JoshFerge
Copy link
Member

  • previously we were getting a random hash associated with the group.
  • now, we simply use event.get_primary_hash()
  • removes passing down these hashes through the various functions as its not needed now
  • deletes a few tests where we were going through edge cases where we weren't finding a group_id associated with the hash .

@JoshFerge JoshFerge requested a review from a team June 4, 2024 17:09
Copy link

sentry-io bot commented Jun 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/tasks/backfill_seer_grouping_records.py

Function Unhandled Issue
backfill_seer_grouping_records KeyError: 5172984251 sentry.tasks.backfill_seer_g...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 4, 2024
@JoshFerge JoshFerge merged commit 27a2f5e into master Jun 4, 2024
48 checks passed
@JoshFerge JoshFerge deleted the jferg/remove-hashes-lookup branch June 4, 2024 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants