ref: fix some typing in hybrid cloud modules #72635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes most errors in these modules when BaseManager becomes typed
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Jun 12, 2024
| @@ -79,7 +79,7 @@ def create_from_request( | |||
| identifier: int | str, | |||
| request: HttpRequest, | |||
| integration_id: int | None = None, | |||
| ) -> Self: | |||
| ) -> WebhookPayload: | |||
There was a problem hiding this comment.
due to an annoying variance issue interacting with a microbug in django-stubs it can't inference cls.objects properly here as also being BaseManager[Self]
markstory
approved these changes
Jun 12, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes most errors in these modules when BaseManager becomes typed