ref(slack): Refactor Link Identity View #72792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72792 +/- ##
========================================
Coverage 78.05% 78.05%
========================================
Files 6601 6605 +4
Lines 294319 294515 +196
Branches 50753 50763 +10
========================================
+ Hits 229725 229886 +161
- Misses 58358 58383 +25
- Partials 6236 6246 +10
|
ykamo001
reviewed
Jun 14, 2024
| except IntegrityError: | ||
| _logger.exception("slack.link.integrity_error") | ||
| metrics.incr( | ||
| self._METRICS_FAILURE_KEYKEY + ".post.identity.integrity_error", |
ykamo001
reviewed
Jun 14, 2024
ykamo001
approved these changes
Jun 17, 2024
Comment on lines
90
to
91
| params.update({"organization": organization, "integration": integration, "idp": idp}) | ||
| return super().dispatch(request, params=params) |
There was a problem hiding this comment.
do we need to update params or could we just pass them into super().dispatch() as specific key word arguments? super().dispatch(org=organization)
Comment on lines
105
to
111
| params = IdentityParams( | ||
| organization=params_dict["organization"], | ||
| integration=params_dict["integration"], | ||
| idp=params_dict["idp"], | ||
| slack_id=params_dict["slack_id"], | ||
| channel_id=params_dict["channel_id"], | ||
| ) |
There was a problem hiding this comment.
Should we do any key error catches here?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/sentry/Slack-ff5b8ab4fd1e4760ab829438ce97ce15
Addresses
bot-3task.Here, I refactored the view to have two separate methods for get and post. I added bunch of logging and metrics & improved tests.