Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: add mypy plugin to fix referencing .objects through a TypeVar #72877

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

asottile-sentry
Copy link
Member

fortunately there's enough plugin hooks that we can work around python/mypy#17395

@asottile-sentry asottile-sentry requested a review from a team June 17, 2024 18:36
@asottile-sentry asottile-sentry requested review from a team as code owners June 17, 2024 18:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2024
@asottile-sentry asottile-sentry force-pushed the asottile-objects-through-typevar branch from bcf5ef6 to 8e3b2b2 Compare June 17, 2024 18:41
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@4de2805). Learn more about missing BASE report.

Current head 8e3b2b2 differs from pull request most recent head bddf533

Please upload reports for the commit bddf533 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #72877   +/-   ##
=========================================
  Coverage          ?   78.04%           
=========================================
  Files             ?     6605           
  Lines             ?   294431           
  Branches          ?    50756           
=========================================
  Hits              ?   229794           
  Misses            ?    58302           
  Partials          ?     6335           
Files Coverage Δ
src/sentry/hybridcloud/models/webhookpayload.py 100.00% <100.00%> (ø)

@asottile-sentry asottile-sentry merged commit de3e607 into master Jun 18, 2024
49 checks passed
@asottile-sentry asottile-sentry deleted the asottile-objects-through-typevar branch June 18, 2024 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants