Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: have models.User extend Model instead of BaseModel #72967

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

asottile-sentry
Copy link
Member

most of our db helpers expected .id to be a Field[int, int] and use Model as the type for that

no migration was generated so I believe this to be a fancy noop

@asottile-sentry asottile-sentry requested review from a team June 18, 2024 20:02
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 18, 2024 20:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2024
most of our db helpers expected .id to be a Field[int, int] and use Model as the type for that
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (4cdd6f9) to head (b3aa840).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72967   +/-   ##
=======================================
  Coverage   78.05%   78.05%           
=======================================
  Files        6610     6610           
  Lines      294851   294866   +15     
  Branches    50811    50817    +6     
=======================================
+ Hits       230144   230159   +15     
+ Misses      58369    58367    -2     
- Partials     6338     6340    +2     
Files Coverage Δ
src/sentry/api/bases/user.py 85.39% <100.00%> (ø)
src/sentry/api/endpoints/api_tokens.py 100.00% <100.00%> (ø)
src/sentry/models/user.py 90.39% <100.00%> (-0.04%) ⬇️
src/sentry/tasks/summaries/weekly_reports.py 85.86% <100.00%> (ø)

... and 8 files with indirect coverage changes

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No migration makes sense to me as there weren't any relevant changes to django model state or the schema.

@asottile-sentry asottile-sentry merged commit 5d711ca into master Jun 20, 2024
49 checks passed
@asottile-sentry asottile-sentry deleted the asottile-user-from-model-not-base-model branch June 20, 2024 13:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants