Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove paranoia star import from sentry.db.models.__init__ #73061

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

asottile-sentry
Copy link
Member

slowly fixing a cycle in sentry.db.models.__init__

slowly fixing a cycle in sentry.db.models.__init__
@asottile-sentry asottile-sentry requested review from a team June 20, 2024 17:22
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 20, 2024 17:22
@asottile-sentry asottile-sentry enabled auto-merge (squash) June 20, 2024 17:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.97%. Comparing base (d8417bb) to head (a487d39).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73061      +/-   ##
==========================================
- Coverage   77.97%   77.97%   -0.01%     
==========================================
  Files        6614     6614              
  Lines      295252   295334      +82     
  Branches    50867    50876       +9     
==========================================
+ Hits       230235   230298      +63     
- Misses      58732    58749      +17     
- Partials     6285     6287       +2     
Files Coverage Δ
src/sentry/db/models/__init__.py 100.00% <ø> (ø)
src/sentry/models/integrations/sentry_app.py 96.24% <100.00%> (+0.02%) ⬆️
...try/models/integrations/sentry_app_installation.py 88.80% <100.00%> (+0.09%) ⬆️

... and 15 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit 32e1413 into master Jun 20, 2024
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-paranoia-star-import branch June 20, 2024 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants