Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: fix passing slug=None to HC slug check #73121

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ref: fix passing slug=None to HC slug check #73121

merged 1 commit into from
Jun 21, 2024

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jun 21, 2024 •
edited
Loading

this currently produces an INFO log on every logged out request

16:38:59 server  | 16:38:59 [INFO] sentry.services.hybrid_cloud: Organization by slug [None] not found

this fixes these two type errors as well:

src/sentry/web/frontend/auth_login.py:509: error: Argument "slug" to "check_organization_by_slug" of "OrganizationService" has incompatible type "str | None"; expected "str"  [arg-type]
src/sentry/web/frontend/auth_login.py:568: error: Argument "slug" to "check_organization_by_slug" of "OrganizationService" has incompatible type "str | None"; expected "str"  [arg-type]

@asottile-sentry
ref: fix passing slug=None to HC slug check
8afcafb 
this produces an INFO log on every logged out request
@asottile-sentry asottile-sentry requested review from a team June 21, 2024 18:43
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 21, 2024 18:43
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 21, 2024
@joshuarli
Copy link
Member

man, typing is good

@asottile-sentry asottile-sentry enabled auto-merge (squash) June 21, 2024 18:46
@asottile-sentry asottile-sentry merged commit 7281bbf into master Jun 21, 2024
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-fix-passing-none-to-slug-check branch June 21, 2024 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshuarli joshuarli joshuarli approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile-sentry @joshuarli