Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(metrics): Update copies #74268

Merged
merged 1 commit into from
Jul 15, 2024
Merged

ref(metrics): Update copies #74268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions static/app/components/metrics/customMetricsEventData.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe('CustomMetricsEventData', () => {
}
);

expect(screen.getByText('Emitted Metrics')).toBeInTheDocument();
expect(screen.getByText('Custom Metrics')).toBeInTheDocument();

expect(screen.getByText('my.metric')).toBeInTheDocument();
expect(screen.getByRole('link', {name: 'View Metric'})).toBeInTheDocument();
Expand Down Expand Up @@ -140,7 +140,7 @@ describe('CustomMetricsEventData', () => {
{organization}
);

expect(screen.getByText('Emitted Metrics')).toBeInTheDocument();
expect(screen.getByText('Custom Metrics')).toBeInTheDocument();

expect(screen.getByText('my.metric')).toBeInTheDocument();
expect(screen.getByRole('link', {name: 'View Metric'})).toBeInTheDocument();
Expand Down Expand Up @@ -174,7 +174,7 @@ describe('CustomMetricsEventData', () => {
}
);

expect(screen.getByText('Emitted Metrics')).toBeInTheDocument();
expect(screen.getByText('Custom Metrics')).toBeInTheDocument();

expect(screen.getByText('my.metric')).toBeInTheDocument();
expect(screen.getByRole('link', {name: 'View Metric'})).toBeInTheDocument();
Expand Down Expand Up @@ -209,7 +209,7 @@ describe('CustomMetricsEventData', () => {
}
);

expect(screen.getByText('Emitted Metrics')).toBeInTheDocument();
expect(screen.getByText('Custom Metrics')).toBeInTheDocument();

expect(screen.getByText('my.metric')).toBeInTheDocument();
expect(screen.getByRole('link', {name: 'View Metric'})).toBeInTheDocument();
Expand Down Expand Up @@ -308,7 +308,7 @@ describe('CustomMetricsEventData', () => {
}
);

expect(screen.getByText('Emitted Metrics')).toBeInTheDocument();
expect(screen.getByText('Custom Metrics')).toBeInTheDocument();

expect(screen.getByText('my.counter')).toBeInTheDocument();
expect(screen.getAllByText('my.distribution')).toHaveLength(2);
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/metrics/customMetricsEventData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export function CustomMetricsEventData({

return (
<TraceDrawerComponents.SectionCard
title={t('Emitted Metrics')}
title={t('Custom Metrics')}
items={items}
sortAlphabetically
/>
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/metrics/pageHeaderActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ export function PageHeaderActions({showAddMetricButton, addCustomMetric}: Props)
},
{
leadingItems: [<IconSettings key="icon" />],
key: 'metrics-settings',
label: t('Metrics Settings'),
key: 'configure-metric',
label: t('Configure Metric'),
onAction: () => navigateTo(`/settings/projects/:projectId/metrics/`, router),
},
],
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/projectMetrics/customMetricsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export function CustomMetricsTable({project}: Props) {
<Fragment>
<SearchWrapper>
<Title>
<h6>{t('Emitted Metrics')}</h6>
<h6>{t('Custom Metrics')}</h6>
{hasCustomMetricsExtractionRules(organization) && (
<Tag type="warning">{t('deprecated')}</Tag>
)}
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/settings/projectMetrics/metricsExtractionRuleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,9 @@ export function MetricsExtractionRuleForm({
}}
/>
<FormField
label={t('Queries')}
label={t('Filters')}
help={t(
'Define queries to narrow down the metric extraction to a specific set of spans.'
'Define filters to narrow down the metric to a specific set of spans.'
)}
name="conditions"
inline={false}
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/settings/projectMetrics/metricsExtractionRulesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function MetricsExtractionRulesTable({project}: Props) {
return (
<Fragment>
<SearchWrapper>
<h6>{t('Span-based Metrics')}</h6>
<h6>{t('Span Metrics')}</h6>
<FlexSpacer />
<SearchBar
placeholder={t('Search Metrics')}
Expand Down Expand Up @@ -147,7 +147,7 @@ function RulesTable({
emptyMessage={
hasSearch
? t('No metrics match the query.')
: t('You have not created any span-based metrics yet.')
: t('You have not created any span metrics yet.')
}
isEmpty={extractionRules.length === 0}
isLoading={isLoading}
Expand Down
Loading