Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: match signature of feature handler has #74856

Merged
merged 1 commit into from
Jul 24, 2024
Merged

ref: match signature of feature handler has #74856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/sentry/api/serializers/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def create_color_handler(color_flag, included_projects):
class ProjectColorFeatureHandler(features.FeatureHandler):
features = {color_flag}

def has(self, feature, actor):
def has(self, feature, actor, skip_entity: bool | None = False):
return feature.project in included_projects

def batch_has(self, *a, **k):
Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/features/test_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def __init__(self, true_set, false_set):
self.true_set = frozenset(true_set)
self.false_set = frozenset(false_set)

def has(self, feature, actor):
def has(self, feature, actor, skip_entity: bool | None = False):
assert actor == test_user

if feature.project in self.true_set:
Expand Down
Loading