Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: unify signature of create_issue #74902

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/plugins/bases/issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def get_issue_label(self, group, issue_id, **kwargs):
"""
return "#%s" % issue_id

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
"""
Creates the issue on the remote service and returns an issue ID.
"""
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/plugins/bases/issue2.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def get_issue_label(self, group, issue, **kwargs):
return "#{}".format(issue["id"])
return f"#{issue}"

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
"""
Creates the issue on the remote service and returns an issue ID.

Expand Down
2 changes: 1 addition & 1 deletion src/sentry/plugins/examples/issue_tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def get_new_issue_fields(self, request: Request, group, event, **kwargs):
*fields,
]

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
return "1"

def get_issue_label(self, group, issue_id, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/asana/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def error_message_from_json(self, data):
return " ".join(e["message"] for e in errors)
return "unknown error"

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
client = self.get_client(request.user)

try:
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/bitbucket/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def message_from_error(self, exc):
return ERR_404
return super().message_from_error(exc)

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
client = self.get_client(request.user)

try:
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/github/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def get_allowed_assignees(self, request: Request, group):

return (("", "Unassigned"),) + users

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
# TODO: support multiple identities via a selection input in the form?
with self.get_client(request.user) as client:
try:
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/gitlab/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def get_client(self, project):

return GitLabClient(url, token)

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
repo = self.get_option("gitlab_repo", group.project)

client = self.get_client(group.project)
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/jira/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def error_message_from_json(self, data):
message += " ".join(f"{k}: {v}" for k, v in data.get("errors").items())
return message

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
cleaned_data = {}

# protect against mis-configured plugin submitting a form without an
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/phabricator/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def view_autocomplete(self, request: Request, group, **kwargs):

return Response({field: results})

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
api = self.get_api(group.project)
try:
data = api.maniphest.createtask(
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/pivotal/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def make_api_request(self, project, _url, json_data=None):
}
return safe_urlopen(_url, json=json_data, headers=req_headers, allow_redirects=True)

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
json_data = {
"story_type": "bug",
"name": force_str(form_data["title"], encoding="utf-8", errors="replace"),
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/redmine/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def get_client(self, project):
host=self.get_option("host", project), key=self.get_option("key", project)
)

def create_issue(self, group, form_data, **kwargs):
def create_issue(self, request, group, form_data):
"""
Create a Redmine issue
"""
Expand Down
2 changes: 1 addition & 1 deletion src/sentry_plugins/trello/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def error_message_from_json(self, data):
return " ".join(e["message"] for e in errors)
return "unknown error"

def create_issue(self, request: Request, group, form_data, **kwargs):
def create_issue(self, request: Request, group, form_data):
client = self.get_client(group.project)

try:
Expand Down
Loading