Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: unify signature of get_projects_list #74972

Merged
merged 1 commit into from
Jul 25, 2024
Merged

ref: unify signature of get_projects_list #74972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/integrations/jira/mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


class MockJira(StubJiraApiClient, MockService):
def get_projects_list(self):
def get_projects_list(self, cached: bool = True):
"""
List all projects in the Jira data format.
Expand Down
2 changes: 1 addition & 1 deletion fixtures/integrations/jira/stub_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def get_priorities(self):
def get_versions(self, project_id):
return self._get_stub_data("versions_response.json")

def get_projects_list(self, cached=True):
def get_projects_list(self, cached: bool = True):
return self._get_stub_data("project_list_response.json")

def get_issue(self, issue_key):
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/integrations/jira_server/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def create_comment(self, issue_key, comment):
def update_comment(self, issue_key, comment_id, comment):
return self.put(self.COMMENT_URL % (issue_key, comment_id), data={"body": comment})

def get_projects_list(self, cached=True):
def get_projects_list(self, cached: bool = True):
if not cached:
return self.get(self.PROJECT_URL)
return self.get_cached(self.PROJECT_URL)
Expand Down
Loading