Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toolbar): add a replay panel for start/stop current replay #75403
feat(toolbar): add a replay panel for start/stop current replay #75403
Changes from 22 commits
6c83718
7c9db6c
72868f6
73d5217
a324791
c1e1ba7
1991afe
9246bac
3ba529b
a7ee558
0219e21
e0a5a52
0359480
c67d984
eeb7485
d9eed6e
1fc533d
286b844
7f9903e
fc8d85a
608e113
1276d6b
7f99b48
fb7bede
f30b5a9
44ed001
bd0d0ef
bcd8f25
697a09a
b9fc69c
87ab1de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use
SentrySDK.getIntegrationByName()
, it's just a bit more annoying dealing with typesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm my VSCode can't find this method in browser or react packages..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm it might be on the SDK client instead of the Sentry namespace... e.g. SentrySDK.getClient().getIntegrationByName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, does this have any improvements over the current approach? Right now I'm using these conditions to get the
disabledReason
(see screenshots I just added in the description)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah just as a fallback if the SDK is too old to support
getReplay
as it was a relatively recent addition, but it's fine not to support older