various date/time-related fixes #75625
Conversation
github-actions
bot
added
the
Scope: Backend
rockdrilla
force-pushed
the
datetimetrials
branch
from
d7e8882
to
4100401
Compare
|
Unfortunately, we're hitting integer overflows on these columns in our self-hosted setup which leads to sentry workers getting stuck and [other] queues growing with blazing speed. |
"abstime" type was removed in that release, see notes: https://www.postgresql.org/docs/12/release-12.html Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
this is merely a mixin of BoundedPositiveIntegerField and BoundedBigIntegerField. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
this field/column easily triggers integer overflow. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
this field/column may trigger integer overflow. NB: "times_seen" is indexed field, so issue REINDEX TABLE after changing column type. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla
force-pushed
the
datetimetrials
branch
from
4100401
to
f9f7c75
Compare
|
@wedamija can't access anymore your reviewed changes after force-pushing branch. May I ask you to review once more? |
Does this mean you have group(s) in your table that have seen over 2 biliion events? In our own production setup, there are none so far with over 1 billion. Are you able to tell me the maximum value of both the |
My main comment is that we can't merge this as is without a lot of work on our end - upgrading the size of a column from an int to a bigint requires a full table lock and will take down our production systems until the rewrite is completed. For us to manage this safely we'd need to figure out a way to manage this change without locking the table. I'm happy to work with you to try and fix the problems in your own system though. |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
No description provided.