fix(self-hosted): SOURCE_COMMIT #76139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2024
|
oh actually this might be coming from |
|
To be honest, this isnt a big deal at all, you don't have to fix this... |
|
the actual fix is in this line, funny typo on my part sentry/.github/workflows/self-hosted.yml Line 88 in 7e9e36a |
This reverts commit ebe8899.
|
github-actions
bot
added
the
Scope: Frontend
hubertdeng123
approved these changes
Aug 14, 2024
aldy505
approved these changes
Aug 15, 2024
joshuarli
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This env var is read by
sentry.get_revision. There are at least 3 self-hosted issue reports of people being confused by the frontend showing somethign like "24.3.0 unknown". Let's make that24.3.0 self hosted.As far as I can tell the sentry version is cosmetic (it isn't validated by anything / doesn't crash the cli):