Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(invite-members): updated invite modal layout and copy/paste functionality #77528

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ameliahsu
Copy link
Member

@ameliahsu ameliahsu commented Sep 13, 2024

improved modal design and added ability for users to copy paste

before:

before.mov

after:

after.mov

next changes:

  • update design for after invites are sent (success/error messages)
  • stop overflow of email address input (want to do that in a separate PR since the SelectControl component is widely used)

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 12.85714% with 61 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../modals/inviteMembersModal/inviteRowControlNew.tsx 8.00% 46 Missing ⚠️
...odals/inviteMembersModal/inviteMembersModalNew.tsx 26.31% 14 Missing ⚠️
...app/components/modals/inviteMembersModal/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77528      +/-   ##
==========================================
+ Coverage   73.75%   78.08%   +4.33%     
==========================================
  Files        6940     6954      +14     
  Lines      308060   308544     +484     
  Branches    50425    50501      +76     
==========================================
+ Hits       227206   240930   +13724     
+ Misses      74233    61226   -13007     
+ Partials     6621     6388     -233     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant