Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(pageFilters): Remove leading icons #77867

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

vuluongj20
Copy link
Member

The leading icons don't offer much additional information. They are not very distinctive, and the labels are usually clear enough to indicate what the filter is (e.g. project avatars are recognizable, so are common env names like prod and stage).

Before ——
Screenshot 2024-09-20 at 12 45 52 PM

Screenshot 2024-09-20 at 12 46 18 PM

Screenshot 2024-09-20 at 12 48 53 PM

After ——
Screenshot 2024-09-20 at 12 47 54 PM

Screenshot 2024-09-20 at 12 47 36 PM

Screenshot 2024-09-20 at 12 47 19 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 20, 2024
@vuluongj20 vuluongj20 merged commit 5ca96fb into master Sep 20, 2024
42 checks passed
@vuluongj20 vuluongj20 deleted the vl/page-filter-icons branch September 20, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants