Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-views): Improve tab switch animations #77890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelSun48
Copy link
Member

Makes the tab switch animation not absolute trash by:

  1. Keeping text static (by only animating it's change in position and not it's change in width)
  2. Slightly delaying when the ellipsis menu animates in (otherwise, as a consequence of keeping the text static, the text will appear behind the ellipsis menu for a moment when switching to that tab)

before:

Screen.Recording.2024-09-22.at.2.35.54.PM.mov

after:

Screen.Recording.2024-09-22.at.2.42.28.PM.mov

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner September 22, 2024 21:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../issueList/groupSearchViewTabs/draggableTabBar.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77890      +/-   ##
==========================================
- Coverage   79.92%   77.99%   -1.93%     
==========================================
  Files        7167     6996     -171     
  Lines      319795   310241    -9554     
  Branches    50763    50763              
==========================================
- Hits       255582   241962   -13620     
+ Misses      58460    56143    -2317     
- Partials     5753    12136    +6383     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant