fix: EAP timeseries order, add weight to calculations #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmak
reviewed
Sep 16, 2024
| return f.sum(key_col, alias="sum") | ||
| if request.aggregate == AggregateBucketRequest.FUNCTION_AVERAGE: | ||
| return f.avg(key_col, alias="avg") | ||
| return f.sum(f.multiply(key_expr, sampling_weight_times_sign), alias="sum") |
There was a problem hiding this comment.
Does this make all the functions the weighted ones by default using sampling_weight_2? Isn't that going to cause some confusion since that column is empty for older data right now
There was a problem hiding this comment.
it defaults to 1, which would be equivalent
Co-authored-by: William Mak <william@wmak.io>
wmak
approved these changes
Sep 16, 2024
phacops
approved these changes
Sep 17, 2024
|
I think we'll need a way to show a summary of the extrapolation: average sampling rate, variance, total count of samples and total extrapolated count. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old tests used the same number a bunch of times, so there was a bug where the results were not ordered by time.
This makes the tests a lot more robust and implements weight in the aggregate functions