(snuba-deletes): storage_deletes_enabled default enabled #6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
reviewed
Sep 20, 2024
| @@ -198,7 +198,6 @@ def test_bad_delete(self) -> None: | |||
| assert "'query' is a required property" in res.get_json()["error"]["message"] | |||
|
|
|||
| # test for invalid column types | |||
| set_config("storage_deletes_enabled", 1) | |||
There was a problem hiding this comment.
Would it make sense to remove these lines?
snuba/tests/test_search_issues_api.py
Lines 158 to 164 in 6fe79f0
There was a problem hiding this comment.
I had left them in just to test that the feature flagging works
armenzg
approved these changes
Sep 20, 2024
onkar
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the default
storage_deletes_enabled=1.Sentry tests should be testing against this feature. In production all regions except S4S have this set to
0. Additionally, only thesearch_issuesdataset has deletes enabled in the storage configuration.