feat(eap): Include server-side sample rates in sampling weight #6333
+16
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new
server_sample_ratemeasurement on spans and includesit in computing the final sampling factor and weight. This allows us to
extrapolate span metrics correctly in organizations that have dynamic sampling
enabled.
This also rounds the sampling factor to a precision of 10^-9 to avoid floating
point errors in the multiplication. For example, without the test using sample
rates of 10% and 20% respectively already shows floating point error.
In a follow-up, we might revise the schema and move these sample rates into
span.data.See getsentry/relay#4063
See getsentry/relay#4038