Added BinaryExpr logic with tests

ghostiam · Sep 6, 2023 · 6e63dcc · 6e63dcc
1 parent b1ab76a
commit 6e63dcc
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/proto.go b/proto.go
@@ -253,6 +253,13 @@ func (c *Checker) Check(expr ast.Expr) {
 		c.Check(x.Index)
 		c.write("]")
 
+	case *ast.BinaryExpr:
+		c.Check(x.X)
+		c.write(" ")
+		c.write(x.Op.String())
+		c.write(" ")
+		c.Check(x.Y)
+
 	default:
 		c.err = fmt.Errorf("checker not implemented for type: %s", reflect.TypeOf(x))
 	}

diff --git a/testdata/test.go b/testdata/test.go
@@ -56,6 +56,9 @@ func testInvalid(t *proto.Test) {
 
 	other := proto.Other{}
 	_ = other.MyMethod(nil).S // want "proto field read without getter:"
+
+	ems := t.RepeatedEmbeddeds // want "proto field read without getter:"
+	_ = ems[len(ems)-1].S      // want "proto field read without getter:"
 }
 
 func testValid(t *proto.Test) {
@@ -113,4 +116,7 @@ func testValid(t *proto.Test) {
 	var tt Test
 	_ = tt.Embedded.GetS()
 	_ = tt.Embedded.GetEmbedded().GetS()
+
+	ems := t.GetRepeatedEmbeddeds()
+	_ = ems[len(ems)-1].GetS()
 }
diff --git a/testdata/test.go.golden b/testdata/test.go.golden
@@ -56,6 +56,9 @@ func testInvalid(t *proto.Test) {
 
 	other := proto.Other{}
 	_ = other.MyMethod(nil).GetS() // want "proto field read without getter:"
+
+	ems := t.GetRepeatedEmbeddeds() // want "proto field read without getter:"
+	_ = ems[len(ems)-1].GetS()      // want "proto field read without getter:"
 }
 
 func testValid(t *proto.Test) {
@@ -113,4 +116,7 @@ func testValid(t *proto.Test) {
 	var tt Test
 	_ = tt.Embedded.GetS()
 	_ = tt.Embedded.GetEmbedded().GetS()
+
+	ems := t.GetRepeatedEmbeddeds()
+	_ = ems[len(ems)-1].GetS()
 }