fix issue #4

ghostiam · Oct 24, 2023 · d7b06e7 · d7b06e7
1 parent af772e8
commit d7b06e7
Show file tree

Hide file tree

Showing 6 changed files with 51 additions and 15 deletions.
diff --git a/processor.go b/processor.go
@@ -31,8 +31,12 @@ func (c *processor) process(n ast.Node) (*Result, error) {
 	switch x := n.(type) {
 	case *ast.AssignStmt:
 		// Skip any assignment to the field.
-		for _, lhs := range x.Lhs {
-			c.filter.AddPos(lhs.Pos())
+		for _, s := range x.Lhs {
+			c.filter.AddPos(s.Pos())
+
+			if se, ok := s.(*ast.StarExpr); ok {
+				c.filter.AddPos(se.X.Pos())
+			}
 		}
 
 	case *ast.IncDecStmt:

diff --git a/testdata/proto/test.pb.go b/testdata/proto/test.pb.go
diff --git a/testdata/proto/test.proto b/testdata/proto/test.proto
@@ -14,6 +14,9 @@ message Test {
   string s = 9;
   Embedded embedded = 10;
   repeated Embedded repeated_embeddeds = 11;
+
+  // issue #4
+  optional bool opt_bool = 12;
 }
 
 message Embedded {

diff --git a/testdata/proto/test_grpc.pb.go b/testdata/proto/test_grpc.pb.go
diff --git a/testdata/test.go b/testdata/test.go
@@ -147,4 +147,12 @@ func testValid(t *proto.Test) {
 	ch <- t.GetS()
 
 	t.Equal(&proto.Test{S: "test", I64: 42})
+
+	// issue #4
+	*t.Embedded = proto.Embedded{}
+
+	v := &proto.Test{
+		OptBool: new(bool),
+	}
+	*v.OptBool = true
 }
diff --git a/testdata/test.go.golden b/testdata/test.go.golden
@@ -147,4 +147,12 @@ func testValid(t *proto.Test) {
 	ch <- t.GetS()
 
 	t.Equal(&proto.Test{S: "test", I64: 42})
+
+	// issue #4
+	*t.Embedded = proto.Embedded{}
+
+	v := &proto.Test{
+		OptBool: new(bool),
+	}
+	*v.OptBool = true
 }