Add null checks in PendingTradesViewModel

These changes were requested in review of PR bisq-network#4699
ghubstan · Oct 30, 2020 · 0656c57 · 0656c57
1 parent c2f8db3
commit 0656c57
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java
@@ -215,18 +215,22 @@ String getMarketLabel(PendingTradesListItem item) {
     }
 
     public String getRemainingTradeDurationAsWords() {
+        checkNotNull(dataModel.getTrade(), "model's trade must not be null");
         return tradeUtil.getRemainingTradeDurationAsWords(dataModel.getTrade());
     }
 
     public double getRemainingTradeDurationAsPercentage() {
+        checkNotNull(dataModel.getTrade(), "model's trade must not be null");
         return tradeUtil.getRemainingTradeDurationAsPercentage(dataModel.getTrade());
     }
 
     public String getDateForOpenDispute() {
+        checkNotNull(dataModel.getTrade(), "model's trade must not be null");
         return DisplayUtils.formatDateTime(tradeUtil.getDateForOpenDispute(dataModel.getTrade()));
     }
 
     public boolean showWarning() {
+        checkNotNull(dataModel.getTrade(), "model's trade must not be null");
         Date halfTradePeriodDate = tradeUtil.getHalfTradePeriodDate(dataModel.getTrade());
         return halfTradePeriodDate != null && new Date().after(halfTradePeriodDate);
     }