Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seconds to thread run times on MacOS. #1292

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Add seconds to thread run times on MacOS. #1292

merged 2 commits into from
Jun 15, 2018

Conversation

nikhilm
Copy link
Contributor

@nikhilm nikhilm commented Jun 10, 2018 •
edited
Loading

Fixes #1278

@giampaolo
Copy link
Owner

Hello, sorry for the delay. This looks good. #1258 appears to be unrelated though. What was the issue you were trying to address? Also, could you please respect the 80 chars per line style? Like this:

            basic_info_th->user_time.seconds + \
                (float)basic_info_th->user_time.microseconds / 1000000.0,
            basic_info_th->system_time.seconds + \
                (float)basic_info_th->system_time.microseconds / 1000000.0

@nikhilm
Copy link
Contributor Author

nikhilm commented Jun 15, 2018

Sorry I meant #1278

@giampaolo giampaolo merged commit 3612b85 into giampaolo:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS thread times are incorrect since they only consider microseconds
2 participants
@nikhilm @giampaolo