Apply our customizations on top of upstream release-2.5 #13
fiunchinhoAnnotations
10 errors and 4 warnings
|
lint:
exp/controllers/awsmachinepool_controller.go#L416
declaration has 3 blank identifiers (dogsled)
|
|
lint:
pkg/cloud/services/s3/s3.go#L540
appendCombine: can combine chain of 2 appends into one (gocritic)
|
|
lint:
pkg/cloud/services/ec2/launchtemplate_test.go#L88
appendCombine: can combine chain of 2 appends into one (gocritic)
|
|
lint:
pkg/cloud/services/s3/s3.go#L222
exported: exported method Service.CreateForMachinePool should have comment or be unexported (revive)
|
|
lint:
pkg/cloud/services/s3/s3.go#L339
exported: exported method Service.DeleteForMachinePool should have comment or be unexported (revive)
|
|
lint:
pkg/cloud/services/autoscaling/autoscalinggroup_test.go#L1183
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
lint:
exp/controllers/awsmanagedmachinepool_controller.go#L224
var-declaration: should drop = nil from declaration of var objectStoreSvc; it is the zero value (revive)
|
|
lint:
pkg/cloud/services/awsnode/cni.go#L285
unnecessary trailing newline (whitespace)
|
|
lint:
exp/controllers/awsmachinepool_controller.go#L416
declaration has 3 blank identifiers (dogsled)
|
|
lint:
pkg/cloud/services/s3/s3.go#L540
appendCombine: can combine chain of 2 appends into one (gocritic)
|
|
lint:
pkg/cloud/services/s3/s3.go#L222
exported: exported method Service.CreateForMachinePool should have comment or be unexported (revive)
|
|
lint:
pkg/cloud/services/s3/s3.go#L339
exported: exported method Service.DeleteForMachinePool should have comment or be unexported (revive)
|
|
lint:
pkg/cloud/services/autoscaling/autoscalinggroup_test.go#L1183
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
lint:
exp/controllers/awsmanagedmachinepool_controller.go#L224
var-declaration: should drop = nil from declaration of var objectStoreSvc; it is the zero value (revive)
|