You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested on an MC with base domain gaws.gigantic.internal, but had set dnsMode to public. Since .internal and other TLDs are reserved for private use, such records will not propagate to public DNS servers. In my case, the workload cluster then failed to come up because Cilium could not look up api.<baseDomain> via DNS. With this change, we throw an error early instead of allowing this human mistake.
λ helm template helm/cluster-aws/ --set organization=bam --set baseDomain=gaws.bla.internal --set network.dnsMode=private
---
# Source: cluster-aws/templates/list.yaml
apiVersion: v1
[...]
# Bad
λ helm template helm/cluster-aws/ --set organization=bam --set baseDomain=gaws.bla.internal --set network.dnsMode=public
Error: execution error at (cluster-aws/templates/list.yaml:7:4): dnsMode=public cannot be combined with a '*.internal' baseDomain since reserved-as-private TLDs are not propagated to public DNS servers and therefore crucial DNS records such as api.<baseDomain> cannot be looked up
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing giantswarm/roadmap#1832 for private clusters
What this PR does / why we need it
Related chat
I tested on an MC with base domain
gaws.gigantic.internal, but had setdnsModetopublic. Since.internaland other TLDs are reserved for private use, such records will not propagate to public DNS servers. In my case, the workload cluster then failed to come up because Cilium could not look upapi.<baseDomain>via DNS. With this change, we throw an error early instead of allowing this human mistake.Checklist
Trigger e2e tests
/test create
/test upgrade