Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention instance refresh warmup settings for CAPA, add general advice #2028

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Dec 21, 2023

What does this PR do?

Towards giantswarm/roadmap#2217, as suggested by @fiunchinho in giantswarm/cluster-aws#457.

Have you maintained the front matter?

yes

@AndiDog AndiDog requested a review from a team as a code owner December 21, 2023 14:43
@fiunchinho
Copy link
Member

The text looks fine. But I was wondering about the 5 minutes warm up. Won't this be a problem on big clusters? We have customers that have clusters with hundreds of nodes. Wouldn't the rolling upgrade take many hours to complete?

@AndiDog
Copy link
Contributor Author

AndiDog commented Dec 21, 2023

The text looks fine. But I was wondering about the 5 minutes warm up. Won't this be a problem on big clusters? We have customers that have clusters with hundreds of nodes. Wouldn't the rolling upgrade take many hours to complete?

From how I understand ASGs, they don't replace one-by-one, but rather based on "minimum healthy percentage". It's 90% by default, I believe, but of course at least one node is replaced at once. For large clusters, that would mean that more than one node would get replaced at once.

@AndiDog AndiDog enabled auto-merge (squash) January 8, 2024 10:27
@AndiDog AndiDog merged commit 033daaa into main Jan 8, 2024
4 of 5 checks passed
@AndiDog AndiDog deleted the instance-warmup branch January 8, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants