Fix build with --no-default-features
#127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid having a defaulted type parameter with `EndianRcSlice` when no features are activated to ensure that the library builds correctly.
|
What's the use case for building this without the alloc feature? I don't think it can do anything useful without allocating. |
|
Ah I see, I was mostly just poking around at rust-lang/backtrace-rs#189 and trying to slim the dependencies as much as possible (in number and enabled features). I was able to work with this crate with no features enabled, but I didn't realize that it still links to Seems like this is probably not necessary in that case regardless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid having a defaulted type parameter with
EndianRcSlicewhen nofeatures are activated to ensure that the library builds correctly.