Remove read feature's dependency on fallible-iterator
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similarly motivated as gimli-rs#494, where the `backtrace` crate will transitively use the `read` feature of `gimli`, so this is intended to prune the dependencies of that dependency tree. This makes the `fallible-iterator` feature optional even when the `read` feature is activated.
alexcrichton
force-pushed
the
optional-fallible-iterator
branch
from
88afa37
to
842fcca
Compare
This was referenced May 7, 2020
philipc
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similarly motivated as #494, where the
backtracecrate willtransitively use the
readfeature ofgimli, so this is intended toprune the dependencies of that dependency tree. This makes the
fallible-iteratorfeature optional even when thereadfeature isactivated.