[Hub Generated] Review request for Microsoft.Authorization to add ver…

…sion preview/2020-04-01-preview (Azure#11506)
giromm2ms · Dec 20, 2020 · a466993 · a466993
1 parent acf1390
commit a466993
Show file tree

Hide file tree

Showing 12 changed files with 228 additions and 4 deletions.
diff --git a/...osoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json b/...osoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json
@@ -112,6 +112,24 @@
     }
   },
   "definitions": {
+    "Error": {
+      "properties": {
+        "error": {
+          "type": "object",
+          "properties": {
+            "code": {
+              "type": "string",
+              "description": "Brief error code"
+            },
+            "message": {
+              "type": "string",
+              "description": "Longer message explaining the details of the error"
+            }
+          }
+        }
+      },
+      "description": "Object to be thrown in case of an unsuccessful response"
+    },
     "ResourceType": {
       "properties": {
         "name": {

diff --git a/...icrosoft.Authorization/preview/2018-01-01-preview/authorization-RoleAssignmentsCalls.json b/...icrosoft.Authorization/preview/2018-01-01-preview/authorization-RoleAssignmentsCalls.json
@@ -478,6 +478,24 @@
     }
   },
   "definitions": {
+    "Error": {
+      "properties": {
+        "error": {
+          "type": "object",
+          "properties": {
+            "code": {
+              "type": "string",
+              "description": "Brief error code"
+            },
+            "message": {
+              "type": "string",
+              "description": "Longer message explaining the details of the error"
+            }
+          }
+        }
+      },
+      "description": "Object to be thrown in case of an unsuccessful response"
+    },
     "RoleAssignmentFilter": {
       "properties": {
         "principalId": {

diff --git a/...icrosoft.Authorization/preview/2018-01-01-preview/authorization-RoleDefinitionsCalls.json b/...icrosoft.Authorization/preview/2018-01-01-preview/authorization-RoleDefinitionsCalls.json
@@ -348,6 +348,24 @@
     }
   },
   "definitions": {
+    "Error": {
+      "properties": {
+        "error": {
+          "type": "object",
+          "properties": {
+            "code": {
+              "type": "string",
+              "description": "Brief error code"
+            },
+            "message": {
+              "type": "string",
+              "description": "Longer message explaining the details of the error"
+            }
+          }
+        }
+      },
+      "description": "Object to be thrown in case of an unsuccessful response"
+    },
     "RoleDefinitionFilter": {
       "properties": {
         "roleName": {

diff --git a/...rosoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json b/...rosoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
@@ -298,6 +298,25 @@
     }
   },
   "definitions": {
+    "Error": {
+      "properties": {
+        "error": {
+          "description": "Object to be thrown in case of an unsuccessful response",
+          "type": "object",
+          "properties": {
+            "code": {
+              "type": "string",
+              "description": "Brief error code"
+            },
+            "message": {
+              "type": "string",
+              "description": "Longer message explaining the details of the error"
+            }
+          }
+        }
+      },
+      "description": "Object to be thrown in case of an unsuccessful response"
+    },
     "DenyAssignmentFilter": {
       "properties": {
         "denyAssignmentName": {

diff --git a/...icrosoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json b/...icrosoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json
@@ -135,6 +135,12 @@
             "schema": {
               "$ref": "#/definitions/RoleAssignmentListResult"
             }
+          },
+          "400": {
+            "description": "Bad Request - Indicates the request has missing information and can not be completed",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
           }
         },
         "x-ms-pageable": {
@@ -181,6 +187,12 @@
             "schema": {
               "$ref": "#/definitions/RoleAssignment"
             }
+          },
+          "204": {
+            "description": "Deleted - Indicates correct deletion without returning additional info"
+          },
+          "412": {
+            "description": "Precondition Failed"
           }
         },
         "x-ms-examples": {
@@ -230,6 +242,18 @@
             "schema": {
               "$ref": "#/definitions/RoleAssignment"
             }
+          },
+          "400": {
+            "description": "Bad Request - Indicates the request has missing information and can not be completed",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
+          },
+          "409": {
+            "description": "Conflict - indicates that the request could not be completed due to a conflict with the current state of the target resource",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
           }
         },
         "x-ms-examples": {
@@ -270,6 +294,15 @@
             "schema": {
               "$ref": "#/definitions/RoleAssignment"
             }
+          },
+          "400": {
+            "description": "Bad Request - Indicates the request has missing information and can not be completed",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
+          },
+          "404": {
+            "description": "Not Found - Indicates the specified role has not been found"
           }
         },
         "x-ms-examples": {
@@ -417,6 +450,12 @@
             "schema": {
               "$ref": "#/definitions/RoleAssignmentListResult"
             }
+          },
+          "400": {
+            "description": "Bad Request - Indicates the request has missing information and can not be completed",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
           }
         },
         "x-ms-pageable": {
@@ -463,6 +502,12 @@
             "schema": {
               "$ref": "#/definitions/RoleAssignmentListResult"
             }
+          },
+          "400": {
+            "description": "Bad Request - Indicates the request has missing information and can not be completed",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
           }
         },
         "x-ms-pageable": {
@@ -540,6 +585,28 @@
         "conditionVersion": {
           "type": "string",
           "description": "Version of the condition. Currently accepted value is '2.0'"
+        },
+        "createdOn": {
+          "type": "string",
+          "description": "Time it was created",
+          "format": "date-time"
+        },
+        "updatedOn": {
+          "type": "string",
+          "description": "Time it was updated",
+          "format": "date-time"
+        },
+        "createdBy": {
+          "type": "string",
+          "description": "Id of the user who created the assignment"
+        },
+        "updatedBy": {
+          "type": "string",
+          "description": "Id of the user who updated the assignment"
+        },
+        "delegatedManagedIdentityResourceId": {
+          "type": "string",
+          "description": "Id of the delegated managed identity resource"
         }
       },
       "description": "Role assignment properties with scope."
@@ -650,6 +717,25 @@
         "properties"
       ],
       "description": "Role assignment create parameters."
+    },
+    "Error": {
+      "properties": {
+        "error": {
+          "description": "Object to be thrown in case of an unsuccessful response",
+          "type": "object",
+          "properties": {
+            "code": {
+              "type": "string",
+              "description": "Brief error code"
+            },
+            "message": {
+              "type": "string",
+              "description": "Longer message explaining the details of the error"
+            }
+          }
+        }
+      },
+      "description": "Object to be thrown in case of an unsuccessful response"
     }
   },
   "parameters": {

diff --git a/...crosoft.Authorization/preview/2020-04-01-preview/examples/DeleteRoleAssignmentByName.json b/...crosoft.Authorization/preview/2020-04-01-preview/examples/DeleteRoleAssignmentByName.json
@@ -21,6 +21,8 @@
         "type": "Microsoft.Authorization/roleAssignments",
         "name": "roleassignmentId"
       }
-    }
+    },
+    "204": {},
+    "412": {}
   }
 }
diff --git a/...er/Microsoft.Authorization/preview/2020-04-01-preview/examples/GetAllRoleAssignments.json b/...er/Microsoft.Authorization/preview/2020-04-01-preview/examples/GetAllRoleAssignments.json
@@ -24,6 +24,14 @@
           }
         ]
       }
+    },
+    "400": {
+      "body": {
+        "error": {
+          "code": "BadRequest",
+          "message": "Your request was badly formed please correct it and try again"
+        }
+      }
     }
   }
 }
diff --git a/.../Microsoft.Authorization/preview/2020-04-01-preview/examples/GetRoleAssignmentByName.json b/.../Microsoft.Authorization/preview/2020-04-01-preview/examples/GetRoleAssignmentByName.json
@@ -22,6 +22,15 @@
         "type": "Microsoft.Authorization/roleAssignments",
         "name": "raId"
       }
-    }
+    },
+    "400": {
+      "body": {
+        "error": {
+          "code": "BadRequest",
+          "message": "Your request was badly formed please correct it and try again"
+        }
+      }
+    },
+    "404": {}
   }
 }
diff --git a/...Microsoft.Authorization/preview/2020-04-01-preview/examples/GetRoleAssignmentByScope.json b/...Microsoft.Authorization/preview/2020-04-01-preview/examples/GetRoleAssignmentByScope.json
@@ -24,6 +24,14 @@
           }
         ]
       }
+    },
+    "400": {
+      "body": {
+        "error": {
+          "code": "BadRequest",
+          "message": "Your request was badly formed please correct it and try again"
+        }
+      }
     }
   }
 }
diff --git a/...Authorization/preview/2020-04-01-preview/examples/GetRoleAssignmentsForResourceGroup.json b/...Authorization/preview/2020-04-01-preview/examples/GetRoleAssignmentsForResourceGroup.json
@@ -25,6 +25,14 @@
           }
         ]
       }
+    },
+    "400": {
+      "body": {
+        "error": {
+          "code": "BadRequest",
+          "message": "Your request was badly formed please correct it and try again"
+        }
+      }
     }
   }
 }
diff --git a/...anager/Microsoft.Authorization/preview/2020-04-01-preview/examples/PutRoleAssignment.json b/...anager/Microsoft.Authorization/preview/2020-04-01-preview/examples/PutRoleAssignment.json
@@ -32,6 +32,22 @@
         "type": "Microsoft.Authorization/roleAssignments",
         "name": "roleassignmentId"
       }
+    },
+    "400": {
+      "body": {
+        "error": {
+          "code": "BadRequest",
+          "message": "Your request was badly formed please correct it and try again"
+        }
+      }
+    },
+    "409": {
+      "body": {
+        "error": {
+          "code": "ConflictError",
+          "message": "the request could not be completed due to a conflict with the current state of the target resource"
+        }
+      }
     }
   }
 }
diff --git a/specification/authorization/resource-manager/readme.md b/specification/authorization/resource-manager/readme.md
@@ -26,7 +26,7 @@ These are the global settings for the Authorization API.
 
 ``` yaml
 openapi-type: arm
-tag: package-2020-04-01-preview-only
+tag: package-2020-04-preview
 ```
 
 ## Suppression
@@ -71,13 +71,27 @@ directive:
 
 ### Tag: package-2020-04-01-preview-only
 
-These settings apply only when `--tag=package-2020-04-preview` is specified on the command line.
+These settings apply only when `--tag=package-2020-04-01-preview-only` is specified on the command line.
 
 ``` yaml $(tag) == 'package-2020-04-01-preview-only'
 input-file:
 - Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json
 ```
 
+### Tag: package-2020-04-preview
+
+These settings apply only when `--tag=package-2020-04-preview` is specified on the command line.
+
+``` yaml $(tag) == 'package-2020-04-preview'
+input-file:
+- Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json
+- Microsoft.Authorization/stable/2015-07-01/authorization-ElevateAccessCalls.json
+- Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json
+- Microsoft.Authorization/preview/2018-01-01-preview/authorization-RoleDefinitionsCalls.json
+- Microsoft.Authorization/preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
+- Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json
+```
+
 ### Tag: package-2015-07-01
 
 These settings apply only when `--tag=package-2015-07-01` is specified on the command line.