Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose metrics for Prometheus Monitoring Framework #1230

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

goettl79
Copy link

@goettl79 goettl79 commented Apr 29, 2017

@gitblit : With this pull request prometheus monitoring metrics are exposed by default. I enabled default metrics for JVM, log4j and custom metrics for git garbage collection and ldap sync latency. The metrics exposed are not complete, so feedback here would be great. Metrics exposed are biased to my needs.

@goettl79 goettl79 force-pushed the PROMETHEUS branch 2 times, most recently from e9933d2 to f2d822e Compare April 29, 2017 14:06
Enabled default log4j metrics collector. The number of log4j log entries will be counted. This enable the following measurable metrics (captured after clean startup gitblit):

 # HELP log4j_appender_total Log4j log statements at various log levels
 # TYPE log4j_appender_total counter
 log4j_appender_total{level="debug",} 0.0
 log4j_appender_total{level="warn",} 1.0
 log4j_appender_total{level="trace",} 0.0
 log4j_appender_total{level="error",} 0.0
 log4j_appender_total{level="fatal",} 0.0
 log4j_appender_total{level="info",} 82.0
Added metrics for:

1. gitblit_garbage_collects_total
2. gitblit_ldap_sync_latency_seconds.

Add gitblit_ prefix to gitblit specific metrics
.) http_request_duration_seconds (histogram) -> Labels (path,method)
.) http_requests_total (counter) -> Labels (path,method,status)

Where path is the REST path of the ressource, method is the HTTP method (GET,PUT..) and
status is the HTTP response code (2xx, 3xx ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant