Skip to content

Commit

Permalink
t-reftable-record: add tests for reftable_log_record_compare_key()
Browse files Browse the repository at this point in the history
reftable_log_record_compare_key() is a function defined by
reftable/record.{c, h} and is used to compare the keys of two
log records when sorting multiple log records using 'qsort'.
In the current testing setup, this function is left unexercised.
Add a testing function for the same.

Mentored-by: Patrick Steinhardt <[email protected]>
Mentored-by: Christian Couder <[email protected]>
Signed-off-by: Chandra Pratap <[email protected]>
Acked-by: Karthik Nayak <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
Chandra Pratap authored and gitster committed Jul 2, 2024
1 parent f7ec13b commit b942fda
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions t/unit-tests/t-reftable-record.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,35 @@ static void t_reftable_log_record_comparison(void)
check(!reftable_record_cmp(&in[0], &in[1]));
}

static void t_reftable_log_record_compare_key(void)
{
struct reftable_log_record logs[3] = {
{
.refname = (char *) "refs/heads/a",
.update_index = 1,
},
{
.refname = (char *) "refs/heads/b",
.update_index = 2,
},
{
.refname = (char *) "refs/heads/a",
.update_index = 3,
},
};

check_int(reftable_log_record_compare_key(&logs[0], &logs[1]), <, 0);
check_int(reftable_log_record_compare_key(&logs[1], &logs[0]), >, 0);

logs[1].update_index = logs[0].update_index;
check_int(reftable_log_record_compare_key(&logs[0], &logs[1]), <, 0);

check_int(reftable_log_record_compare_key(&logs[0], &logs[2]), >, 0);
check_int(reftable_log_record_compare_key(&logs[2], &logs[0]), <, 0);
logs[2].update_index = logs[0].update_index;
check_int(reftable_log_record_compare_key(&logs[0], &logs[2]), ==, 0);
}

static void t_reftable_log_record_roundtrip(void)
{
struct reftable_log_record in[] = {
Expand Down Expand Up @@ -510,6 +539,7 @@ int cmd_main(int argc, const char *argv[])
TEST(t_reftable_index_record_comparison(), "comparison operations work on index record");
TEST(t_reftable_obj_record_comparison(), "comparison operations work on obj record");
TEST(t_reftable_ref_record_compare_name(), "reftable_ref_record_compare_name works");
TEST(t_reftable_log_record_compare_key(), "reftable_log_record_compare_key works");
TEST(t_reftable_log_record_roundtrip(), "record operations work on log record");
TEST(t_reftable_ref_record_roundtrip(), "record operations work on ref record");
TEST(t_varint_roundtrip(), "put_var_int and get_var_int work");
Expand Down

0 comments on commit b942fda

Please sign in to comment.