Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: release on specific labels #67

Merged
merged 3 commits into from
Apr 29, 2024
Merged

feat: release on specific labels #67

merged 3 commits into from
Apr 29, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 28, 2024 •
edited
Loading

Related to github/github-ospo#105

Pull Request

Proposed Changes

Only generate a release and new action container images if our semver related labels (breaking, enhancement, fix) or the release label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with release if it is a dependabot or manual pull request related to a CVE or security fix.

  • update CONTRIBUTING.md with new release information
  • manually add vuln and release labels to repository

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@jmeridth
feat: release on specific labels
e22ebd8 
Related to github/github-ospo#105

Only generate a release and new action container images
if our semver related labels (`breaking`, `enhancement`) or
the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation
happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having
to make API cals.

Currently we'd still need to label a pull request with `release` if
it is a dependabot or manual pull request related to a CVE or security
fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Apr 28, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner April 28, 2024 23:44
@jmeridth
Copy link
Member Author

@zkoppert how do you feel about fix being a minor bump (aka causes a release)? Or do we want to batch after a few fixes and the PR we decide to release on, we manually add the release label? 🤔

zkoppert
zkoppert reviewed Apr 29, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
zkoppert
zkoppert approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work for forks and not trigger for closed but not merged PRs. Looks great!

@zkoppert
Copy link
Member

@zkoppert how do you feel about fix being a minor bump (aka causes a release)? Or do we want to batch after a few fixes and the PR we decide to release on, we manually add the release label? 🤔

To me, fix means that we fixed a bug. Since we don't rate bugs by severity I'd prefer to get those bug fixes out the door (shipped) as soon as possible by cutting a release.

jmeridth and others added 2 commits April 29, 2024 13:14
@jmeridth @zkoppert
Update CONTRIBUTING.md
172a355 
Co-authored-by: Zack Koppert <zkoppert@github.com>
@jmeridth
chore: change fix label to bump minor semver
1929150 
this will cause a release to happen immediately when a fix labelled PR is merged

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth
Copy link
Member Author

@zkoppert how do you feel about fix being a minor bump (aka causes a release)? Or do we want to batch after a few fixes and the PR we decide to release on, we manually add the release label? 🤔

To me, fix means that we fixed a bug. Since we don't rate bugs by severity I'd prefer to get those bug fixes out the door (shipped) as soon as possible by cutting a release.

@zkoppert fix moved in .github/release.yml to minor semver bump. thank you for feedback.

@jmeridth jmeridth merged commit 1de7aaa into main Apr 29, 2024
25 checks passed
@jmeridth jmeridth deleted the jm-specific-labels-for-releases branch April 29, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

Assignees

@jmeridth jmeridth

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmeridth @zkoppert