Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cmark_init_standard_node_flags #305

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Deprecate cmark_init_standard_node_flags #305

merged 1 commit into from
Jan 25, 2023

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: #303

I added cmark_init_standard_node_flags() in 420c20a, but it was a mistake because it caused backwards-compatibility issues for clients who use cmark-gfm as a library.

@kevinbackhouse
Copy link
Collaborator Author

I wish I could use the [[deprecated]] attribute, but it's a C23 feature so it would involve adding set(CMAKE_C_STANDARD 23) to our cmake config which might also cause problems for our users.

@kevinbackhouse kevinbackhouse merged commit 459b8d0 into github:master Jan 25, 2023
@kevinbackhouse kevinbackhouse deleted the deprecate-cmark_init_standard_node_flags branch January 25, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anticomputer anticomputer anticomputer approved these changes

@phillmv phillmv Awaiting requested review from phillmv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release notes for v0.29.0.gfm.7 don't mention new cmark_init_standard_node_flags() function
2 participants
@kevinbackhouse @anticomputer